Skip to content

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Oct 6, 2025

Could I have a review of a PR that retries if a Thread Context Switch Rate event is not emitted on Windows? This is similar to TestCPULoad.

Testing: 500 * jdk/jdk/jfr/event/TestThreadContextSwitches.java

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8247776: JFR: TestThreadContextSwitches.java failed "RuntimeException: No events: expected false, was true" (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27654/head:pull/27654
$ git checkout pull/27654

Update a local copy of the PR:
$ git checkout pull/27654
$ git pull https://git.openjdk.org/jdk.git pull/27654/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27654

View PR using the GUI difftool:
$ git pr show -t 27654

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27654.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 6, 2025

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@egahlin egahlin marked this pull request as ready for review October 6, 2025 17:28
@egahlin egahlin changed the title 8247776: JFR TestThreadContextSwitches.java failed "RuntimeException: No events: expected false, was true" 8247776: JFR: TestThreadContextSwitches.java failed "RuntimeException: No events: expected false, was true" Oct 6, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 6, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant